1944 graduated from the Medical College of West China Sheikh University with a doctorate. He used to be a lecturer in this college.

After the founding of the People's Republic of China, he has served as an associate professor, professor and director of ophthalmology in Peking Union Medical College Hospital, honorary director of the Ophthalmology Research Center of China Academy of Medical Sciences, vice chairman of the Ophthalmology Society of Chinese Medical Association, chairman of the Ophthalmology Professional Committee of the Medical Science Committee of the Ministry of Health, and deputy head of the national technical guidance group for preventing blindness. He has been engaged in ophthalmology clinical, teaching and scientific research for a long time, and has unique features in glaucoma treatment. He has written papers such as Vitreous Transplantation.