1925 ——1926 studied at Beijing Hosei University.
1926 ——1932 studied in the physics department of Peking University, and obtained a bachelor of science degree.
1932- 1933, teaching assistant of Peking University, lecturer of Beijing Women's College of Arts and Sciences.
1933 ——1947 served as an assistant, associate researcher and full-time researcher of academia sinica.
1947- 1953 was the curator of Shanghai Science Museum (1945- 1948), and he was also a professor at the Central Institute of Surveying and Mapping and Tongji University.
1953- 1957, consultant and engineer of Shanghai comprehensive instrument factory, professor of Zhejiang university.
1957 ——1958 as a consultant engineer of Shanghai Institute of Optical Instruments.
1958 ——1977, successively served as an engineer of Shanghai optical instrument research institute and Shanghai optical instrument factory. (1958 Visiting Professor of Shanghai Jiaotong University in the second half of the year).
1977 retired.
1986 died in Shanghai.